[#1449] feat(catalogs): Introudce new module bundled-catalog for query engine.
#1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diqiu50
reviewed
Jan 11, 2024
diqiu50
reviewed
Jan 11, 2024
...va/com/datastrato/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 11, 2024
| exclude("**/*.conf") | ||
| exclude("**/*.so") | ||
| exclude("**/*.sxd") | ||
| exclude("**/*.ddl") |
There was a problem hiding this comment.
Did you exclude everything and only leave something you wanted?
There was a problem hiding this comment.
Yes, the final jar is like this.
jerryshao
reviewed
Jan 11, 2024
catalogs/catalog-common/src/main/java/com/datastrato/catalog/common/ClassProvider.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 11, 2024
...g-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveSchemaPropertiesMetadata.java
Outdated
Show resolved
Hide resolved
|
@jerryshao @diqiu50 |
jerryshao
reviewed
Jan 12, 2024
jerryshao
reviewed
Jan 12, 2024
catalogs/catalog-common/src/main/java/com/datastrato/catalog/common/ClassProvider.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 12, 2024
.../com/datastrato/gravitino/trino/connector/catalog/hive/TestHiveCatalogPropertyConverter.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 15, 2024
| @@ -77,12 +77,12 @@ dependencies { | |||
| tasks { | |||
| val copyDepends by registering(Copy::class) { | |||
| from(configurations.runtimeClasspath) | |||
| into("build/libs") | |||
| into("build/libs_all") | |||
There was a problem hiding this comment.
What is the purpose of this change?
There was a problem hiding this comment.
The build and copyDepends tasks of catalog-hive use the same output directory 'build/libs', which is needed by task shadowJar in bundled-catalog, gradle will get errors and says "task shadowJar depends on task copyDepends".
There was a problem hiding this comment.
You'd better add comment on the file to describe it.
.../com/datastrato/gravitino/trino/connector/catalog/hive/TestHiveCatalogPropertyConverter.java
Outdated
Show resolved
Hide resolved
yuqi1129
changed the title
catalog-common for query engine.bundled-catalog for query engine.
jerryshao
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
bundled-catalogto hold common information like property meta of all catalogsbundled-catalogtotrino-connectordependency and verify everything is OK.Why are the changes needed?
We need a common module to hold the property meta of all catalogs so that the query engine depends on it can use it for query.
Fix: #1449
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Add some UT in module
Trino-connector